michaeljmarshall commented on code in PR #15304:
URL: https://github.com/apache/pulsar/pull/15304#discussion_r857891976
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/LinuxInfoUtils.java:
##########
@@ -254,7 +254,7 @@ public double convertBy(double usageBytes) {
@AllArgsConstructor
public enum UsageUnit {
- Kbps(8 / 1024);
+ Kbps(8 / 1000);
Review Comment:
Nit: this enum's name was confusing to me. After digging through the code, I
can see that this enum's role is to convert the host's bytes in/out into
kilobits in/out for comparison against the kilobits/sec rate. It could be
valuable to either rename this enum or add a comment to the enum for future
readers of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
