Technoboy- commented on code in PR #15296:
URL: https://github.com/apache/pulsar/pull/15296#discussion_r859327112
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java:
##########
@@ -432,4 +433,27 @@ protected void validateTopicName(String property, String
namespace, String encod
throw new RestException(Response.Status.PRECONDITION_FAILED,
"Topic name is not valid");
}
}
+
+ protected void internalScaleTransactionCoordinators(AsyncResponse
asyncResponse, int replicas) {
Review Comment:
We should define this method as `protected CompletableFuture<Void>
internalScaleTransactionCoordinators`,
which means we can't pass `AsyncResponse` into the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
