michaeljmarshall commented on code in PR #14756: URL: https://github.com/apache/pulsar/pull/14756#discussion_r861444936
########## conf/proxy.conf: ########## @@ -274,3 +274,8 @@ zookeeperSessionTimeoutMs=-1 # ZooKeeper cache expiry time in seconds # Deprecated: use metadataStoreCacheExpirySeconds zooKeeperCacheExpirySeconds=-1 + +### --- Metrics --- ### + +# Whether the '/metrics' endpoint requires authentication. Defaults to tru Review Comment: ```suggestion # Whether the '/metrics' endpoint requires authentication. Defaults to true ``` ########## conf/broker.conf: ########## @@ -1230,6 +1230,9 @@ webSocketMaxTextFrameSize=1048576 ### --- Metrics --- ### +# Whether the '/metrics' endpoint requires authentication. Defaults to false +authenticateMetricsEndpoint=false Review Comment: Leaving this `false` is backwards compatible, but I wonder if we should make the "breaking" change and enable authentication by default here? Note that this config only takes effect when authentication is enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
