zymap commented on code in PR #14450:
URL: https://github.com/apache/pulsar/pull/14450#discussion_r865581535
##########
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.java:
##########
@@ -223,6 +222,13 @@ private void downloadFile(File pkgFile, boolean
isPkgUrlProvided, FunctionMetaDa
if (downloadFromHttp) {
FunctionCommon.downloadFromHttpUrl(pkgLocationPath, tempPkgFile);
+ } else if (workerConfig.isFunctionsWorkerEnablePackageManagement()) {
Review Comment:
We download with the package service at line 232, why need a new branch? And
if we download failed, don't we need to throw the exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
