Technoboy- commented on code in PR #14153:
URL: https://github.com/apache/pulsar/pull/14153#discussion_r865607965
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4135,15 +4156,15 @@ private CompletableFuture<Void>
createSubscriptions(TopicName topicName, int num
// Pulsar client-java lib always passes user-agent as X-Java-$version.
// However, cpp-client older than v1.20 (PR #765) never used to pass it.
// So, request without user-agent and Pulsar-CPP-vX (X < 1.21) must be
rejected
- private void validateClientVersion() {
+ protected CompletableFuture<Void> internalValidateClientVersionAsync() {
Review Comment:
yes, only make this method to return future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
