Technoboy- opened a new pull request, #15454:
URL: https://github.com/apache/pulsar/pull/15454

   ### Motivation
   When `roleClaim` is a String, it will return an empty list.
   
https://github.com/apache/pulsar/blob/afc48e64cb161eb3fd1e00f5f997ea8f00fe66ab/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/MultiRolesTokenAuthorizationProvider.java#L113-L126
   We should return the singletonList.
   
   Method `authorize` using the common pool thread and has a sync call :
   
https://github.com/apache/pulsar/blob/afc48e64cb161eb3fd1e00f5f997ea8f00fe66ab/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/MultiRolesTokenAuthorizationProvider.java#L137-L161
   And if line-141 has an exception, the future could not complete.
   
   
   ### Documentation
   
   - [x] `no-need-doc` 
   (Please explain why)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to