liangyepianzhou commented on code in PR #15424:
URL: https://github.com/apache/pulsar/pull/15424#discussion_r865998560
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TopicTransactionBuffer.java:
##########
@@ -275,6 +286,7 @@ public CompletableFuture<TransactionBufferReader>
openTransactionBufferReader(Tx
@Override
public CompletableFuture<Void> commitTxn(TxnID txnID, long lowWaterMark) {
+ lowWaterMarks.compute(txnID.getMostSigBits(), (k, v) -> lowWaterMark);
Review Comment:
Good suggestion, I think you are right. The method
`endTxnInTransactionBuffer` is asynchronous, we can not grantee the order of
committed operation .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
