mattisonchao opened a new pull request, #15479: URL: https://github.com/apache/pulsar/pull/15479
### Motivation Current, we use PersistentAcknowledgmentsGroupingTracker#isDuplicate to do our best effort to deduplicate messages. the original comments as below: ``` Since the ack are delayed, we need to do some best-effort duplicate check to discard messages that are being resent after a disconnection and for which the user has already sent an acknowledgement. ``` Following this principle, we can improve our logic in ack flush. when the consumer state is not ready, we don't need to flush the ack to the wrong broker. which can help `isDuplicate` be more effective in some cases. ### Modifications - If the consumer state is not `ready`, we don't need to flush the ack. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Documentation - [x] `no-need-doc` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
