liangyepianzhou commented on code in PR #15472:
URL: https://github.com/apache/pulsar/pull/15472#discussion_r867287216
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionMetadataStore.java:
##########
@@ -374,8 +374,8 @@ public CompletableFuture<Void> updateTxnStatus(TxnID txnID,
TxnStatus newStatus,
if (newStatus == TxnStatus.COMMITTED ||
newStatus == TxnStatus.ABORTED) {
transactionLog.deletePosition(txnMetaListPair.getRight()).whenComplete((v, ex)
-> {
if (ex != null) {
- promise.completeExceptionally(ex);
- return;
+ log.warn("Failed to delete
transaction log position "
+ + "at end transaction
[{}]", txnID);
Review Comment:
Maybe we should change the way we clean data. Change the way from individual
Ack to cumulative Ack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
