eolivelli commented on code in PR #15478:
URL: https://github.com/apache/pulsar/pull/15478#discussion_r867436696
##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java:
##########
@@ -246,7 +259,10 @@ public boolean isHelp() {
@Parameter(names = { "-h", "--help" }, description = "Show this help
message")
private boolean help = false;
+ private boolean usingNew211Defaults;
Review Comment:
Using version smells a little from my point ofbview.
What about using PIP117 as reference?
usingPIP117Defaults
or we can invert the flag and name it 'useLegscyDefaults' and cite this PIP
with a link
##########
pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java:
##########
@@ -246,7 +259,10 @@ public boolean isHelp() {
@Parameter(names = { "-h", "--help" }, description = "Show this help
message")
private boolean help = false;
+ private boolean usingNew211Defaults;
+
public void start() throws Exception {
+ usingNew211Defaults = !Paths.get(zkDir).toFile().exists();
Review Comment:
Os this is true maybe we could log a line explaining that we found the
directory and we are switching to the old defaults
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
