Technoboy- commented on code in PR #14858:
URL: https://github.com/apache/pulsar/pull/14858#discussion_r867686056
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -577,11 +577,9 @@ protected void
internalCreatePartitionedTopic(AsyncResponse asyncResponse, int n
Policies policies = getNamespacePolicies(namespaceName);
maxTopicsPerNamespace = policies.max_topics_per_namespace;
} catch (RestException e) {
- if (e.getResponse().getStatus() !=
Status.NOT_FOUND.getStatusCode()) {
- log.error("[{}] Failed to create partitioned topic {}",
clientAppId(), namespaceName, e);
- resumeAsyncResponseExceptionally(asyncResponse, e);
- return;
- }
+ log.error("[{}] Failed to create partitioned topic {}",
clientAppId(), namespaceName, e);
Review Comment:
> I believe we fixed some similar problem in v2 API. with this change if you
did not create the namespace you cannot create a topic, and this makes much
sense to me.
>
> probably before this change you were able to create a topic to a non
existing namespace.
>
> we must ensure that the behaviour is consistent across v2 and v1
I think after this fix, we have made it's consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
