Huanli-Meng commented on code in PR #15507:
URL: https://github.com/apache/pulsar/pull/15507#discussion_r868776041
##########
site2/website/versioned_docs/version-2.8.0/developing-binary-protocol.md:
##########
@@ -382,6 +382,29 @@ Parameters:
* `validation_error` → *(optional)* Indicates that the consumer has discarded
the messages due to: `UncompressedSizeCorruption`,
`DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC ID, `txnid_most_bits` and
`txnid_least_bits`
Review Comment:
```suggestion
* `txnid_most_bits` -> *(optional)* Same as the TC ID. `txnid_most_bits`
and `txnid_least_bits`
```
The TC ID means Transaction ID or something else? If yes, it looks you use
Transaction ID in the following section. It's better to unify them.
##########
site2/website/versioned_docs/version-2.8.0/developing-binary-protocol.md:
##########
@@ -382,6 +382,29 @@ Parameters:
* `validation_error` → *(optional)* Indicates that the consumer has discarded
the messages due to: `UncompressedSizeCorruption`,
`DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
+ * `txnid_most_bits` -> *(optional)* Same as TC ID, `txnid_most_bits` and
`txnid_least_bits`
+ uniquely identify a transaction.
+ * `txnid_least_bits` -> *(optional)* The ID of the transaction opened in a TC,
+ `txnid_most_bits` and `txnid_least_bits`uniquely identify a transaction.
+ * `request_id` -> *(optional)* ID for handling response and timeout.
+
+
+ ##### Command AckResponse
+
+An `AckResponse` is the broker’s response to acknowledge a request sent by the
client. It contains the `consumer_id` sent in the request.
+If a transaction is used, it contains both Transaction ID and Request ID that
are sent in the request. The client finishes the specific request according to
the Request ID. If the `error` field is set, it indicates that the request has
failed.
Review Comment:
```suggestion
If a transaction is used, it contains both the Transaction ID and the
Request ID that are sent in the request. The client finishes the specific
request according to the Request ID. If the `error` field is set, it indicates
that the request has failed.
```
##########
site2/website/versioned_docs/version-2.8.0/developing-binary-protocol.md:
##########
@@ -382,6 +382,29 @@ Parameters:
* `validation_error` → *(optional)* Indicates that the consumer has discarded
the messages due to: `UncompressedSizeCorruption`,
`DecompressionError`, `ChecksumMismatch`, `BatchDeSerializeError`
+ * `properties` -> *(optional)* Reserved configuration items
Review Comment:
why would you like to use "->" instead of ":"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
