jerrypeng commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273307241
########## File path: pulsar-client-cpp/python/pulsar/functions/context.py ########## @@ -126,7 +126,8 @@ def record_metric(self, metric_name, metric_value): @abstractmethod def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None, callback=None): Review comment: actually @sijie if you look at the commit you commented on. The signature of contextimpl.publish didn't change. Thus context.py did not need to be updated ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
