jerrypeng commented on issue #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#issuecomment-481085772 @sijie in my previous comment, I already said I was going to add the tests. Please read my responses in their entirety before responding. On Mon, Apr 8, 2019 at 8:07 PM Sijie Guo <[email protected]> wrote: > *@sijie* commented on this pull request. > ------------------------------ > > In pulsar-client-cpp/python/pulsar/functions/context.py > <https://github.com/apache/pulsar/pull/4005#discussion_r273310264>: > > > @@ -126,7 +126,8 @@ def record_metric(self, metric_name, metric_value): > @abstractmethod > def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None, callback=None): > > Sure I might be commenting in between commits. but my question is still > there : how can we guarantee the fix is correct? where are the tests for > this change? > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/pulsar/pull/4005#discussion_r273310264>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/ADcir6hlv1dcxwEj9LyuwhTw3xsfOlI-ks5vfAPtgaJpZM4ci9Wj> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
