wolfstudy commented on a change in pull request #4008: [go function]support log topic for go function URL: https://github.com/apache/pulsar/pull/4008#discussion_r273585701
########## File path: pulsar-function-go/pf/logAppender.go ########## @@ -0,0 +1,87 @@ +// Review comment: For logAppender, the significance of unit testing may not be very large, we need integration testing to run the entire logic to verify the correctness of the code. As you can see, the logAppender code itself is relatively simple logic, similar to: create producer, close producer and so on. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
