Shawyeok opened a new pull request, #15594:
URL: https://github.com/apache/pulsar/pull/15594
### Motivation
Currently we are abuse `PulsarClientException`, I think we could use a more
meaningful derived exception instead. For example, call `acknowledge` on an
already closed consumer throws PulsarClientException with message `Consumer
already closed`, it's hard for caller to determine what kind of exception they
catch.
### Modifications
It's safe to use a derived exception instead of PulsarClientException.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [x] `no-need-doc`
It's just refactoring work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
