Technoboy- commented on code in PR #15603:
URL: https://github.com/apache/pulsar/pull/15603#discussion_r873302412
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java:
##########
@@ -63,24 +63,18 @@ public class TenantsBase extends PulsarWebResource {
@ApiResponses(value = {@ApiResponse(code = 403, message = "The requester
doesn't have admin permissions"),
@ApiResponse(code = 404, message = "Tenant doesn't exist")})
public void getTenants(@Suspended final AsyncResponse asyncResponse) {
- final String clientAppId = clientAppId();
- try {
- validateSuperUserAccess();
- } catch (Exception e) {
- asyncResponse.resume(e);
- return;
- }
- tenantResources().listTenantsAsync().whenComplete((tenants, e) -> {
- if (e != null) {
- log.error("[{}] Failed to get tenants list", clientAppId, e);
- asyncResponse.resume(new RestException(e));
- return;
- }
- // deep copy the tenants to avoid concurrent sort exception
- List<String> deepCopy = new ArrayList<>(tenants);
- deepCopy.sort(null);
- asyncResponse.resume(deepCopy);
- });
+ validateSuperUserAccessAsync()
+ .thenCompose(__ -> tenantResources().listTenantsAsync())
+ .thenAccept(tenants -> {
+ // deep copy the tenants to avoid concurrent sort exception
+ List<String> deepCopy = new ArrayList<>(tenants);
+ deepCopy.sort(null);
+ asyncResponse.resume(deepCopy);
Review Comment:
Ah, this seems ok, we return a new list to the user, so we don't care the
result, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
