sijie commented on a change in pull request #4015: Allow to configure
TypedMessageBuilder through a Map conf object
URL: https://github.com/apache/pulsar/pull/4015#discussion_r273742337
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
##########
@@ -130,6 +131,32 @@ public MessageId send() throws PulsarClientException {
return this;
}
+ @SuppressWarnings("unchecked")
+ @Override
+ public TypedMessageBuilder<T> loadConf(Map<String, Object> config) {
+ config.forEach((key, value) -> {
+ if (key.equals("key")) {
Review comment:
Can we define CONSTANTS for those keys? It is better to use CONSTANTS to
avoid any typos when using this approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
