eolivelli commented on code in PR #15653:
URL: https://github.com/apache/pulsar/pull/15653#discussion_r876718709
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -834,9 +835,11 @@ protected void internalSetAutoTopicCreation(AsyncResponse
asyncResponse,
"Invalid configuration for autoTopicCreationOverride.
the detail is "
+ validateResult.getErrorInfo());
}
- if (maxPartitions > 0 &&
autoTopicCreationOverride.getDefaultNumPartitions() > maxPartitions) {
- throw new RestException(Status.NOT_ACCEPTABLE,
- "Number of partitions should be less than or equal to
" + maxPartitions);
+ if (Objects.equals(autoTopicCreationOverride.getTopicType(),
TopicType.PARTITIONED.toString())) {
+ if (maxPartitions > 0 &&
autoTopicCreationOverride.getDefaultNumPartitions() > maxPartitions) {
Review Comment:
But you should add the null check anyway. Because here we can fail with NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
