cbornet commented on code in PR #15671:
URL: https://github.com/apache/pulsar/pull/15671#discussion_r876937957
##########
pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java:
##########
@@ -424,6 +425,27 @@ public void testCreateFunctionWithInvalidPackageUrl()
throws Exception {
verify(functions,
times(0)).createFunctionWithUrl(any(FunctionConfig.class), anyString());
}
+ @Test
+ public void testCreateFunctionWithBuiltinNar() throws Exception {
+ cmd.run(new String[] {
+ "create",
+ "--name", FN_NAME,
+ "--inputs", INPUT_TOPIC_NAME,
+ "--output", OUTPUT_TOPIC_NAME,
+ "--jar", BUILTIN_NAR,
Review Comment:
> with Sinks there is no need to pass the classname
Yes this should not be required. Do I fix it in this PR or another one ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
