mattisonchao commented on code in PR #15674:
URL: https://github.com/apache/pulsar/pull/15674#discussion_r877009512
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java:
##########
@@ -394,20 +398,27 @@ public CompletableFuture<Void> messageAcked(CommandAck
ack) {
}
if (ack.hasTxnidMostBits() && ack.hasTxnidLeastBits()) {
List<PositionImpl> positionsAcked =
Collections.singletonList(position);
- return transactionCumulativeAcknowledge(ack.getTxnidMostBits(),
+ future =
transactionCumulativeAcknowledge(ack.getTxnidMostBits(),
ack.getTxnidLeastBits(), positionsAcked);
} else {
List<Position> positionsAcked =
Collections.singletonList(position);
subscription.acknowledgeMessage(positionsAcked,
AckType.Cumulative, properties);
- return CompletableFuture.completedFuture(null);
+ future = CompletableFuture.completedFuture(null);
}
} else {
if (ack.hasTxnidLeastBits() && ack.hasTxnidMostBits()) {
- return individualAckWithTransaction(ack);
+ future = individualAckWithTransaction(ack);
} else {
- return individualAckNormal(ack, properties);
+ future = individualAckNormal(ack, properties);
}
}
+
+ return future
Review Comment:
This change will ignore exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
