315157973 commented on code in PR #15607: URL: https://github.com/apache/pulsar/pull/15607#discussion_r877230058
########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/RangeSetWrapper.java: ########## @@ -0,0 +1,169 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.mledger.impl; + +import static com.google.common.base.Preconditions.checkNotNull; +import com.google.common.annotations.VisibleForTesting; +import com.google.common.collect.Range; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import org.apache.bookkeeper.mledger.ManagedLedgerConfig; +import org.apache.pulsar.common.util.collections.ConcurrentOpenLongPairRangeSet; +import org.apache.pulsar.common.util.collections.LongPairRangeSet; + +/** + * Wraps other Range classes, and adds LRU, marking dirty data and other features on this basis. + * This range set is not thread safety. + * + * @param <T> + */ +public class RangeSetWrapper<T extends Comparable<T>> implements LongPairRangeSet<T> { + + private final LongPairRangeSet<T> rangeSet; + private final LongPairConsumer<T> rangeConverter; + private final ManagedLedgerConfig config; + private final boolean enableMultiEntry; + + /** + * Record which Ledger is dirty. + */ + private final DefaultRangeSet<Long> dirtyLedgers = new LongPairRangeSet.DefaultRangeSet<>( + (LongPairConsumer<Long>) (key, value) -> key); + + public RangeSetWrapper(LongPairConsumer<T> rangeConverter, ManagedCursorImpl managedCursor) { Review Comment: Yes, it is useless at this stage. But in the later part, we will use it. In order not to modify the interface, I will pass it in now ########## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/RangeSetWrapper.java: ########## @@ -0,0 +1,169 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.bookkeeper.mledger.impl; + +import static com.google.common.base.Preconditions.checkNotNull; +import com.google.common.annotations.VisibleForTesting; +import com.google.common.collect.Range; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import org.apache.bookkeeper.mledger.ManagedLedgerConfig; +import org.apache.pulsar.common.util.collections.ConcurrentOpenLongPairRangeSet; +import org.apache.pulsar.common.util.collections.LongPairRangeSet; + +/** + * Wraps other Range classes, and adds LRU, marking dirty data and other features on this basis. + * This range set is not thread safety. + * + * @param <T> + */ +public class RangeSetWrapper<T extends Comparable<T>> implements LongPairRangeSet<T> { + + private final LongPairRangeSet<T> rangeSet; + private final LongPairConsumer<T> rangeConverter; Review Comment: Yes, it is useless at this stage. But in the later part, we will use it. In order not to modify the interface, I will pass it in now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
