sijie commented on a change in pull request #4022: Making use of builtin
schemas for primitive types
URL: https://github.com/apache/pulsar/pull/4022#discussion_r274246664
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/TopicSchema.java
##########
@@ -104,20 +96,41 @@ private SchemaType getSchemaTypeOrDefault(String topic,
Class<?> clazz) {
}
private static SchemaType getDefaultSchemaType(Class<?> clazz) {
- if (byte[].class.equals(clazz)
- || ByteBuf.class.equals(clazz)
- || ByteBuffer.class.equals(clazz)) {
- return SchemaType.NONE;
+ if (byte[].class.equals(clazz)) {
Review comment:
Can you explain why this is changed from SchemaType.NONE to SchemaType.BYTES?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
