shibd commented on code in PR #15491:
URL: https://github.com/apache/pulsar/pull/15491#discussion_r880250358
##########
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarRecord.java:
##########
@@ -93,6 +95,15 @@ public Optional<Long> getEventTime() {
}
}
+ /**
+ * Some sink sometimes wants to control the ack type.
+ *
+ * @param cumulative
+ */
+ public void ack(boolean cumulative) {
Review Comment:
I think this is similar to the API now provided, if provide `ackCumulative`
or `cumulativeAck` instead it, will easily make the original `ack` method
understood as `Individual ack`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
