Technoboy- commented on code in PR #15755:
URL: https://github.com/apache/pulsar/pull/15755#discussion_r881437452
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LockManagerImpl.java:
##########
@@ -173,15 +173,13 @@ public CompletableFuture<Void> asyncClose() {
if (state != State.Ready) {
return CompletableFuture.completedFuture(null);
}
-
locks = new HashMap<>(this.locks);
this.state = State.Closed;
}
-
return FutureUtils.collect(
- locks.values().stream()
- .map(ResourceLock::release)
- .collect(Collectors.toList()))
+ locks.values().stream()
Review Comment:
I will update when everything is ok
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/coordination/impl/LockManagerImpl.java:
##########
@@ -173,15 +173,13 @@ public CompletableFuture<Void> asyncClose() {
if (state != State.Ready) {
return CompletableFuture.completedFuture(null);
}
-
locks = new HashMap<>(this.locks);
this.state = State.Closed;
}
-
return FutureUtils.collect(
- locks.values().stream()
- .map(ResourceLock::release)
- .collect(Collectors.toList()))
+ locks.values().stream()
Review Comment:
I will update when everything is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
