congbobo184 commented on code in PR #15140:
URL: https://github.com/apache/pulsar/pull/15140#discussion_r881453319
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/buffer/TransactionBufferClientTest.java:
##########
@@ -148,6 +154,59 @@ public void testAbortOnSubscription() throws
ExecutionException, InterruptedExce
}
}
+
+ @Test
+ public void testTransactionBufferMetrics() throws Exception {
+ //Test commit
+ for (int i = 0; i < partitions; i++) {
+ String topic = partitionedTopicName.getPartition(i).toString();
+ tbClient.commitTxnOnSubscription(topic, "test", 1L, i, -1L).get();
+ }
+
+ //test abort
+ for (int i = 0; i < partitions; i++) {
+ String topic = partitionedTopicName.getPartition(i).toString();
+ tbClient.abortTxnOnSubscription(topic, "test", 1L, i, -1L).get();
+ }
+
+ @Cleanup
+ ByteArrayOutputStream statsOut = new ByteArrayOutputStream();
+ PrometheusMetricsGenerator.generate(pulsarServiceList.get(0), true,
false, false, statsOut);
+ String metricsStr = statsOut.toString();
+ Multimap<String, PrometheusMetricsTest.Metric> metricsMap =
PrometheusMetricsTest.parseMetrics(metricsStr);
+
+ Collection<PrometheusMetricsTest.Metric> abortFailed =
metricsMap.get("pulsar_txn_tb_client_abort_failed");
+ Collection<PrometheusMetricsTest.Metric> commitFailed =
metricsMap.get("pulsar_txn_tb_client_commit_failed");
+ Collection<PrometheusMetricsTest.Metric> abortLatencyCount =
+ metricsMap.get("pulsar_txn_tb_client_abort_latency_count");
+ Collection<PrometheusMetricsTest.Metric> commitLatencyCount =
+ metricsMap.get("pulsar_txn_tb_client_commit_latency_count");
+ Collection<PrometheusMetricsTest.Metric> pending =
metricsMap.get("pulsar_txn_tb_client_pending_requests");
+
+ assertEquals(abortFailed.stream().mapToDouble(metric ->
metric.value).sum(), 0);
+ assertEquals(commitFailed.stream().mapToDouble(metric ->
metric.value).sum(), 0);
+
+ for (int i = 0; i < partitions; i++) {
+ String topic = partitionedTopicName.getPartition(i).toString();
+ Optional<PrometheusMetricsTest.Metric> optional =
abortLatencyCount.stream()
+ .filter(metric ->
metric.tags.get("topic").equals(topic)).findFirst();
+
+ assertTrue(optional.isPresent());
+ assertEquals(optional.get().value, 1D);
+
+ Optional<PrometheusMetricsTest.Metric> optional1 =
commitLatencyCount.stream()
+ .filter(metric ->
metric.tags.get("topic").equals(topic)).findFirst();
+ assertTrue(optional1.isPresent());
+ assertEquals(optional1.get().value, 1D);
+ }
+
+ assertEquals(pending.size(), 1);
+
+ for (PrometheusMetricsTest.Metric metric : pending) {
+ assertTrue(metric.value >= 0D);
Review Comment:
should add the request to pending and check the value > 0D is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
