zymap commented on code in PR #15063:
URL: https://github.com/apache/pulsar/pull/15063#discussion_r861427829
##########
tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlockAwareSegmentInputStreamTest.java:
##########
@@ -226,7 +236,12 @@ public void testHaveEndPadding() throws Exception {
// verify read inputStream
// 1. read header. 128
byte headerB[] = new byte[DataBlockHeaderImpl.getDataStartOffset()];
- ByteStreams.readFully(inputStream, headerB);
+ if (useBufferRead) {
+ int ret = inputStream.read(headerB, 0,
DataBlockHeaderImpl.getDataStartOffset());
Review Comment:
Added new test to cover this
https://github.com/apache/pulsar/pull/15063/files#diff-1f2edfe47e5f4f0d8b1634a21eeaccf78eb36d05c55d1c02f20f146247926defR764
##########
tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlockAwareSegmentInputStreamTest.java:
##########
@@ -226,7 +236,12 @@ public void testHaveEndPadding() throws Exception {
// verify read inputStream
// 1. read header. 128
byte headerB[] = new byte[DataBlockHeaderImpl.getDataStartOffset()];
- ByteStreams.readFully(inputStream, headerB);
+ if (useBufferRead) {
+ int ret = inputStream.read(headerB, 0,
DataBlockHeaderImpl.getDataStartOffset());
Review Comment:
Added a new test to cover this
https://github.com/apache/pulsar/pull/15063/files#diff-1f2edfe47e5f4f0d8b1634a21eeaccf78eb36d05c55d1c02f20f146247926defR764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
