michaeljmarshall commented on PR #15483:
URL: https://github.com/apache/pulsar/pull/15483#issuecomment-1139246495
> @michaeljmarshall The `@Secret` is not recognized by jackson writer.
@Shoothzj - I don't believe that is correct. When I remove the `@JsonIgnore`
annotations that you added, and run your test while logging the output, here is
what I get:
```
{"serviceUrl":null,"authPluginClassName":null,"authParams":null,"authParamMap":null,"operationTimeoutMs":30000,"lookupTimeoutMs":30000,"statsIntervalSeconds":60,"numIoThreads":1,"numListenerThreads":1,"connectionsPerBroker":1,"useTcpNoDelay":true,"useTls":false,"tlsTrustCertsFilePath":"","tlsAllowInsecureConnection":false,"tlsHostnameVerificationEnable":true,"concurrentLookupRequest":5000,"maxLookupRequest":50000,"maxLookupRedirects":20,"maxNumberOfRejectedRequestPerConnection":50,"keepAliveIntervalSeconds":30,"connectionTimeoutMs":10000,"requestTimeoutMs":60000,"initialBackoffIntervalNanos":100000000,"maxBackoffIntervalNanos":60000000000,"enableBusyWait":false,"listenerName":null,"useKeyStoreTls":false,"sslProvider":null,"tlsTrustStoreType":"JKS","tlsTrustStorePath":null,"tlsTrustStorePassword":"*****","tlsCiphers":[],"tlsProtocols":[],"memoryLimitBytes":67108864,"proxyServiceUrl":null,"proxyProtocol":null,"enableTransaction":false,"dnsLookupBindAddress":null,"dnsLookupBindPort":
0,"socks5ProxyAddress":null,"socks5ProxyUsername":null,"socks5ProxyPassword":"*****"}
```
Note that the `@Secret` fields correctly have `****` in the names.
The `@Secret` annotation was added here,
https://github.com/apache/pulsar/pull/8910, and the annotation's interface
definitely shows an integration with Jackson. That being said, perhaps you
found a case where the Jackson serializer wasn't interpreting the annotation
correctly? I'm not familiar enough with custom annotations to know, but it
seems like the old behavior was working in unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
