horizonzy commented on PR #15104:
URL: https://github.com/apache/pulsar/pull/15104#issuecomment-1140121808
Sure
发自我的iPhone
------------------ Original ------------------
From: Qiang Zhao ***@***.***>
Date: Sat,May 28,2022 8:46 AM
To: apache/pulsar ***@***.***>
Cc: Yan Zhao ***@***.***>, Mention ***@***.***>
Subject: Re: [apache/pulsar] [cleanup] [broker] Remove useless code to
avoidconfusion in OpReadEntry#checkReadCompletion (PR #15104)
This PR need to cherry-pick to another branch, because when invoke
cursor.ledger.startReadOperationOnLedger(nextReadPosition, OpReadEntry.this);
twice may cause NPE when ledger id equals null and then failed this OpAddEntry
and recycle it.
@codelipenghui @horizonzy Could you help to confirm it?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]