truong-hua commented on PR #6077: URL: https://github.com/apache/pulsar/pull/6077#issuecomment-1143900012
> @codelipenghui overall looks good. however we need to take care of two things: > > 1. the backward compatibility of the newly introduced setting. > 2. what is the "inactive" behavior for subscriptions all caught up? IMO A topic should be treated as an inactive topic in `delete_when_subscriptions_caught_up` mode when meet all the following conditions: > > a) no messages published for a while (larger than the max inactive duration). b) no producers connected to this topic. c) no backlog. > > I don't think we need to check if there are consumers connected. > > Also I noticed that you indicated that this pull request fixes #4824. However I don't think this pull request fixes the problem in #4824. So that would be considered to remove from the description. Otherwise when we close this pull request, it will accidentally close #4824 I agree that we not include the condition that consumers have to be inactive. The consumers usually be keep running to provide low latency message processing and so they are always active as much as possible, which will prevent the inactive topic to be cleaned up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
