Technoboy- commented on code in PR #15880:
URL: https://github.com/apache/pulsar/pull/15880#discussion_r887420343
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/Namespaces.java:
##########
@@ -849,12 +849,20 @@ public DispatchRate
getDispatchRate(@PathParam("property") String property, @Pat
@Path("/{property}/{cluster}/{namespace}/subscriptionDispatchRate")
@ApiOperation(value = "Set Subscription dispatch-rate throttling for all
topics of the namespace")
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have
admin permission") })
- public void setSubscriptionDispatchRate(@PathParam("property") String
property,
+ public void setSubscriptionDispatchRate(@Suspended AsyncResponse
asyncResponse,
+ @PathParam("property") String
property,
@PathParam("cluster") String
cluster,
@PathParam("namespace") String
namespace,
DispatchRateImpl dispatchRate) {
validateNamespaceName(property, cluster, namespace);
- internalSetSubscriptionDispatchRate(dispatchRate);
+ internalSetSubscriptionDispatchRateAsync(dispatchRate)
+ .thenAccept(__ ->
asyncResponse.resume(Response.noContent().build()))
+ .exceptionally(ex -> {
+ log.error("Failed to set the subscription dispatchRate for
cluster on namespace {}",
Review Comment:
We add clientAppId in the log like :l
log.error("[{}] Failed to set the subscription dispatchRate for cluster on
namespace {}", clientAppId(), namespaceName, ex);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
