congbobo184 commented on code in PR #15718:
URL: https://github.com/apache/pulsar/pull/15718#discussion_r887795955
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryServiceImpl.java:
##########
@@ -178,15 +178,8 @@ public
CompletableFuture<List<CompletableFuture<SchemaAndMetadata>>> getAllSchem
@NotNull
public CompletableFuture<SchemaVersion> putSchemaIfAbsent(String schemaId,
SchemaData schema,
Review Comment:
First I agree with you, that when the admin API creates Schema should check
the schema Compatibility first, but this method is putSchemaIfAbsent, if the
schema exists, we should return the SchemaVersion, so I don't think we should
change this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
