liangyepianzhou commented on code in PR #15654:
URL: https://github.com/apache/pulsar/pull/15654#discussion_r888599392
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
##########
@@ -861,18 +865,26 @@ public CompletableFuture<PendingAckHandle>
pendingAckHandleFuture() {
public TransactionPendingAckStats getStats() {
TransactionPendingAckStats transactionPendingAckStats = new
TransactionPendingAckStats();
transactionPendingAckStats.state = this.getState().name();
+ transactionPendingAckStats.recoverStartTime =
recoverTime.getRecoverStartTime();
+ transactionPendingAckStats.recoverEndTime =
recoverTime.getRecoverEndTime();
return transactionPendingAckStats;
}
public synchronized void completeHandleFuture() {
if (!this.pendingAckHandleCompletableFuture.isDone()) {
this.pendingAckHandleCompletableFuture.complete(PendingAckHandleImpl.this);
}
+ if (recoverTime.getRecoverStartTime() == 0L) {
Review Comment:
Transaction pending ack is lazy loading. There may not start to recover.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
