michaeljmarshall commented on code in PR #15637:
URL: https://github.com/apache/pulsar/pull/15637#discussion_r888633378


##########
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/WorkerServer.java:
##########
@@ -171,18 +174,52 @@ private void init() {
         server.setConnectors(connectors.toArray(new 
ServerConnector[connectors.size()]));
     }
 
-    public static ServletContextHandler newServletContextHandler(String 
contextPath,
+    private static class FilterInitializer {

Review Comment:
   I see that this class is duplicated across several classes. What is the 
motivation for duplicating the code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to