boatrainlsz opened a new pull request, #15947:
URL: https://github.com/apache/pulsar/pull/15947
Fixes #15844
### Motivation
JsonSchema doesn't remove reserved
keys(`_default`,`_required`,`_required_default`) when being encoded. Resulting
in confusing encoding output.
### Modifications
Extract a common method to remove reserved keys when JsonSchema is being
encoded, and this common method will be called when JsonSchema::encode method
is called.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- *Added a unit test method named
test_json_schema_encode_remove_reserved_key, see
pulsar-client-cpp/python/schema_test.py*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / **no**)
- Anything that affects deployment: (yes / **no** / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
