mattisonchao commented on code in PR #15944:
URL: https://github.com/apache/pulsar/pull/15944#discussion_r890773773
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -565,6 +565,25 @@ protected CompletableFuture<PartitionedTopicMetadata>
internalGetPartitionedMeta
});
}
+ protected CompletableFuture<Map<String, String>>
internalGetPropertiesAsync(boolean authoritative) {
+ return validateTopicOperationAsync(topicName,
TopicOperation.GET_METADATA)
+ .thenCompose(__ ->
pulsar().getBrokerService().fetchPartitionedTopicMetadataAsync(topicName))
+ .thenCompose(metadata -> {
+ if (metadata.partitions == 0 || topicName.isPartitioned())
{
Review Comment:
When `topicName.isPartitioned()` is true, the `metadata.partitions` may
always equals to 0 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
