sijie commented on a change in pull request #3904: [go schema] support go
schema for pulsar-client-go
URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130716
##########
File path: pulsar-client-cpp/lib/c/c_ConsumerConfiguration.cc
##########
@@ -40,6 +40,19 @@ pulsar_consumer_type
pulsar_consumer_configuration_get_consumer_type(
return
(pulsar_consumer_type)consumer_configuration->consumerConfiguration.getConsumerType();
}
+void
pulsar_consumer_configuration_set_schema_type(pulsar_consumer_configuration_t
*consumer_configuration,
Review comment:
@wolfstudy
it seems that we never pass in properties for schema. that means that the
properties users specify in go is not passed to c client and sent to broker.
also isn't it clear to have a method in consumer_configuration to
set_schema_info and get_schema_info?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
