[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15809: Add new draft of architecture-overview.md and accompanying images, add under-construction.md and accompanying images

[GitBox]

Anonymitaet commented on code in PR #15809:
URL: https://github.com/apache/pulsar/pull/15809#discussion_r893129507


##########
site2/docs/architecture-overview.md:
##########
@@ -0,0 +1,143 @@
+---
+
+id: concepts-architecture-overview
+
+title: Architecture overview
+
+sidebar_label: Concepts

Review Comment:
   1. currently we have a chapter named "Architecture", its title name is 
"Architecture overview" as well 
   https://pulsar.apache.org/docs/next/concepts-architecture-overview
   do you want to create a new chapter named "Concepts" which is parallel to 
"Architecture"? or place the existing one? can you explain your intention? we 
usually explain the motivation in PR description
   
   <img width="327" alt="image" 
src="https://user-images.githubusercontent.com/50226895/172788806-97e12166-d829-480c-9ea7-4364c110dca0.png";>
   <img width="472" alt="image" 
src="https://user-images.githubusercontent.com/50226895/172788927-a07cb63a-a760-43e3-9c2c-a1e9c38d44f8.png";>
   
   
   2. as we discussed yesterday, to reduce potential issues, we'd better keep 
this (metadata) format the same as other files, which is removing blank lines 
and adding quotes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org