Technoboy- commented on code in PR #15877:
URL: https://github.com/apache/pulsar/pull/15877#discussion_r894123677
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -366,6 +360,9 @@ private void doIndividualBatchAckAsync(BatchMessageIdImpl
batchMessageId) {
return value;
});
bitSet.clear(batchMessageId.getBatchIndex());
+ if (pendingIndividualBatchIndexAcks.size() >= MAX_ACK_GROUP_SIZE) {
+ flush();
+ }
Review Comment:
> `doIndividualBatchAck` also invokes `doIndividualBatchAckAsync`, what's
the difference?
Maybe the name of the method is a little inappropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
