[GitHub] [pulsar] codelipenghui commented on a diff in pull request #15761: [fix][client] Remove consumer when close consumer command is received

Fri, 10 Jun 2022 03:17:11 -0700 


codelipenghui commented on code in PR #15761:
URL: https://github.com/apache/pulsar/pull/15761#discussion_r894376775


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -115,6 +115,7 @@ public class ClientCnx extends PulsarHandler {
                     .expectedItems(16)
                     .concurrencyLevel(1)
                     .build();
+    @Getter

Review Comment:
   It's better to return an immutable map to prevent anyone to modify it 
externally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to