tisonkun opened a new pull request, #16004:
URL: https://github.com/apache/pulsar/pull/16004

   This is a chore job to cleanup files.
   
   ### Motivation
   
   Although https://github.com/cbeust/testng/issues/508 is open, we should take 
care of TestNG configuration when config `maven-surefire-plugin` instead of 
repeating this note here and there:
   
   ```xml
   <plugin>
       <groupId>org.apache.maven.plugins</groupId>
       <artifactId>maven-surefire-plugin</artifactId>
       <configuration>
           <!-- Lines below are important -->
           <suiteXmlFiles>
               <file>src/test/resources/pulsar.xml</file>
           </suiteXmlFiles>
           <forkCount>1</forkCount>
       </configuration>
   </plugin>
   ```
   
   I think this knowledge should go to somewhere in CONTRIBUTING.md or if we 
have a developer guide, and spread among contributors, instead of pollute TODO 
comments here and there - we can do nothing.
   
   Also, if I understand the tests trigger logic right, filed removed in this 
PR is unused.
   
   ### Modifications
   
   Remove unused TestNG conf files and clean up repeated notes
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   It's an internal change.
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   
   Internal change.
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to