Radiancebobo opened a new pull request, #16023:
URL: https://github.com/apache/pulsar/pull/16023

   allowAutoTopicCreation and allowAutoTopicCreationType etc should be 
dynamically configured
   
   <!--
   ### Contribution Checklist
     
     - PR title format should be *[type][component] summary*. For details, see 
*[Guideline - Pulsar PR Naming 
Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
 
   
     - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
     
     - Each pull request should address only one issue, not mix up code from 
multiple issues.
     
     - Each commit in the pull request has a meaningful commit message
   
     - Once all items of the checklist are addressed, remove the above text and 
this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   Fixes #16020 
   
   
   ### Motivation
   In the broker.conf configuration, there are these configurations:
   
   - allowAutoTopicCreation
   - allowAutoTopicCreationType
   - brokerDeleteInactiveTopicsEnabled
   - brokerDeleteInactiveTopicsFrequencySeconds
   - brokerDeleteInactiveTopicsMaxInactiveDurationSeconds
   - allowAutoSubscriptionCreation
   I think these should be dynamically configurable.
   
   Pulsar has namespace-level policy, but the broker-level dynamically  
configuration is missing. 
   
   
   ### Modifications
   The change is very simple, just add dynamic identification to these 
configurations in ServiceConfiguration.java, and add a callback function when 
updating.
   
   
   ### Documentation
   
   
   Need to update docs? 
   
   - [x] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   
   - [x] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to