codelipenghui commented on code in PR #16045:
URL: https://github.com/apache/pulsar/pull/16045#discussion_r897989610


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java:
##########
@@ -233,7 +233,7 @@ private void writeHAProxyMessage() {
                 InetSocketAddress clientAddress = (InetSocketAddress) 
inboundChannel.remoteAddress();
                 String sourceAddress = 
clientAddress.getAddress().getHostAddress();
                 int sourcePort = clientAddress.getPort();
-                InetSocketAddress proxyAddress = (InetSocketAddress) 
inboundChannel.remoteAddress();
+                InetSocketAddress proxyAddress = (InetSocketAddress) 
outboundChannel.localAddress();

Review Comment:
   I think it should be the address that the client requested. Actually, the 
`destinationAddress` is useless for now since we introduced HAProxyMessage only 
for getting the real client address even if users use other L4 proxies or the 
Pulsar proxy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to