AnonHxy commented on code in PR #16084:
URL: https://github.com/apache/pulsar/pull/16084#discussion_r900690652
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -2371,11 +2371,9 @@ private void updateTopicMessageDispatchRate() {
this.pulsar().getExecutor().execute(() -> {
// update message-rate for each topic
forEachTopic(topic -> {
- if (topic instanceof AbstractTopic) {
- ((AbstractTopic) topic).updateBrokerDispatchRate();
- }
- if (topic.getDispatchRateLimiter().isPresent()) {
- topic.getDispatchRateLimiter().get().updateDispatchRate();
+ if (topic instanceof PersistentTopic) {
Review Comment:
> Further more, we can add dispatchRateLimiter for non-persistent-topic in
the future
It looks better if we add `updateDispatchRateLimiter()` as `AbstractTopic`
method. @Jason918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
