mans2singh opened a new pull request, #16130:
URL: https://github.com/apache/pulsar/pull/16130
Fixes #16082
### Motivation
* The help option for set retention indicates `-t` option is `Retention time
in minutes` but if no time unit is specified, it is assumed to be seconds.
### Modifications
* Updated description for time option and added unit test cases with default
value (without time unit suffix) and with seconds time unit.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
- Added unit tests for to `PulsarAdminToolTests with and without time unit
suffix.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
