Jason918 commented on code in PR #16095:
URL: https://github.com/apache/pulsar/pull/16095#discussion_r901218887
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1614,6 +1614,35 @@ private void
internalUpdateSubscriptionPropertiesForNonPartitionedTopic(AsyncRes
});
}
+ private void
internalGetSubscriptionPropertiesForNonPartitionedTopic(AsyncResponse
asyncResponse,
+
String subName,
+
boolean authoritative) {
+ validateTopicOwnershipAsync(topicName, authoritative)
+ .thenRun(() -> validateTopicOperation(topicName,
TopicOperation.CONSUME))
+ .thenApply(__ -> {
+ Topic topic = getTopicReference(topicName);
Review Comment:
better to use `getTopicReferenceAsync()`?
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java:
##########
@@ -98,6 +99,7 @@ public CmdTopics(Supplier<PulsarAdmin> admin) {
jcommander.addCommand("unsubscribe", new DeleteSubscription());
jcommander.addCommand("create-subscription", new CreateSubscription());
jcommander.addCommand("update-subscription-properties", new
UpdateSubscriptionProperties());
+ jcommander.addCommand("update-subscription-properties", new
GetSubscriptionProperties());
Review Comment:
```suggestion
jcommander.addCommand("get-subscription-properties", new
GetSubscriptionProperties());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
