Technoboy- commented on code in PR #16141:
URL: https://github.com/apache/pulsar/pull/16141#discussion_r902213429
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1208,24 +1207,24 @@ protected CompletableFuture<? extends TopicStats>
internalGetStatsAsync(boolean
getEarliestTimeInBacklog));
}
- protected PersistentTopicInternalStats internalGetInternalStats(boolean
authoritative, boolean metadata) {
+ protected CompletableFuture<PersistentTopicInternalStats>
internalGetInternalStatsAsync(boolean authoritative,
+
boolean metadata) {
+ CompletableFuture<Void> ret;
if (topicName.isGlobal()) {
- validateGlobalNamespaceOwnership(namespaceName);
- }
- validateTopicOwnership(topicName, authoritative);
- validateTopicOperation(topicName, TopicOperation.GET_STATS);
-
- Topic topic = getTopicReference(topicName);
- try {
- if (metadata) {
- validateTopicOperation(topicName, TopicOperation.GET_METADATA);
- }
- return topic.getInternalStats(metadata).get();
- } catch (Exception e) {
- log.error("[{}] Failed to get internal stats for {}",
clientAppId(), topicName, e);
- throw new RestException(Status.INTERNAL_SERVER_ERROR,
- (e instanceof ExecutionException) ?
e.getCause().getMessage() : e.getMessage());
+ ret = validateGlobalNamespaceOwnershipAsync(namespaceName);
+ } else {
+ ret = CompletableFuture.completedFuture(null);
}
+ return ret.thenCompose(__ -> validateTopicOwnershipAsync(topicName,
authoritative))
+ .thenCompose(__ -> validateTopicOperationAsync(topicName,
TopicOperation.GET_STATS))
+ .thenCompose(__ -> {
+ if (metadata) {
+ return validateTopicOperationAsync(topicName,
TopicOperation.GET_METADATA);
+ }
+ return null;
Review Comment:
return `CompletableFuture.completedFuture(null)`;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
