andrasbeni commented on code in PR #16062:
URL: https://github.com/apache/pulsar/pull/16062#discussion_r902834448
##########
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java:
##########
@@ -1474,6 +1477,55 @@ public static ByteBuf
newEndTxnOnSubscriptionResponse(long requestId, long txnId
return serializeWithSize(cmd);
}
+ public static BaseCommand newWatchTopicList(
+ long requestId, long watcherId, String namespace, String
topicsPattern, String topicsHash) {
+ BaseCommand cmd = localCmd(Type.WATCH_TOPIC_LIST);
+ cmd.setWatchTopicList()
+ .setRequestId(requestId)
+ .setNamespace(namespace)
Review Comment:
Yes, that feature would make sense to me. However, the linked pull request
has seen no progress for almost two years, so if you don't mind I would like
to keep the namespace parameter, for now, to simplify detecting when a metadata
store notification is related to topics that match. Otherwise, it is more
difficult to distinguish between topics in v1 namespaces and subscriptions in
v2 namespaces. Or would you have a simple solution to that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
