merlimat commented on issue #4062: Delayed message delivery implementation URL: https://github.com/apache/pulsar/pull/4062#issuecomment-484069171 > I have looked into the pull request. This is actually a simpler implementation of PIP-26. Is that a bad thing? Is there any limitation in this approach? > If so, how does this PR address the concerns raised when PIP-26 was started (i.e. making changes to dispatcher). The changes to the dispatcher itself have been isolated in a very few specific points. It should be easy to review and verify that with feature turned off there's zero impact in current behavior. The biggest difference with this PR is that the tracking happens entirely off-heap, in direct memory. There are no objects created and retained for extended amount of time, which is the pattern that will kill the GC performances. A topic will have ByteBuf using direct memory where the priority queue is stored. On the data path there are no other allocations required.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
