nodece commented on code in PR #16183:
URL: https://github.com/apache/pulsar/pull/16183#discussion_r904457887
##########
tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileStoreBackedReadHandleImpl.java:
##########
@@ -90,9 +90,10 @@ public LedgerMetadata getLedgerMetadata() {
@Override
public CompletableFuture<Void> closeAsync() {
CompletableFuture<Void> promise = new CompletableFuture<>();
- executor.submit(() -> {
+ executor.execute(() -> {
try {
reader.close();
+ promise.complete(null);
Review Comment:
The promise is complete in line 145.
##########
tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileStoreBackedReadHandleImpl.java:
##########
@@ -90,9 +90,10 @@ public LedgerMetadata getLedgerMetadata() {
@Override
public CompletableFuture<Void> closeAsync() {
CompletableFuture<Void> promise = new CompletableFuture<>();
- executor.submit(() -> {
+ executor.execute(() -> {
try {
reader.close();
+ promise.complete(null);
Review Comment:
The promise is complete in line 144.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
